Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The events from pallet scheduler are not complete #344

Open
brandonpille opened this issue May 10, 2023 · 2 comments
Open

The events from pallet scheduler are not complete #344

brandonpille opened this issue May 10, 2023 · 2 comments
Labels
I3-annoyance The code behaves as expected, but "expected" is an issue.

Comments

@brandonpille
Copy link

brandonpille commented May 10, 2023

The events defined in the struct

type EventRecords struct {
are not in line with the one from substrate: https://github.com/paritytech/substrate/blob/e92613d9a4f4e85b57a2dd891765c407f0ad2549/frame/scheduler/src/lib.rs#LL257C3-L257C3

These are missing:

  • CallUnavailable
  • PeriodicFailed
  • PermanentlyOverweight

I noticed the ones from Utility are also incomplete. These are missing:

	Utility_BatchCompletedWithErrors []EventBatchCompletedWithErrors       `test-gen-blockchain:"centrifuge-parachain"`
	Utility_ItemFailed               []EventItemFailed                     `test-gen-blockchain:"centrifuge-parachain"`
	Utility_DispatchedAs             []EventDispatchedAs                   `test-gen-blockchain:"centrifuge-parachain"`
@mustermeiszer mustermeiszer added the I3-annoyance The code behaves as expected, but "expected" is an issue. label May 10, 2023
@mustermeiszer
Copy link

cc @cdamian as I am a go noob...

@cdamian
Copy link
Contributor

cdamian commented Dec 5, 2023

@brandonpille we added support for dynamically decoding events, you can find an example here - https://github.com/centrifuge/go-substrate-rpc-client/blob/master/registry/retriever/event_retriever_live_test.go#L52

We will stop updating the hardcoded event types eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I3-annoyance The code behaves as expected, but "expected" is an issue.
Projects
None yet
Development

No branches or pull requests

3 participants