Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(packaging): various issues + migration to JSON config file #5291

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(packaging): various issues + migration to JSON config file #5291

merged 1 commit into from
Nov 28, 2024

Conversation

omercier
Copy link
Contributor

@omercier omercier commented Nov 18, 2024 •
edited
Loading

Description

  • missing dependency on AlmaLinux
  • /etc/(default|sysconfig)/centreon_vmware was ignored
  • migrate the config file from .pm to .json

Refs: CTOR-1079

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Try:

  • a fresh install
  • an upgrade from a version using the legacy .pm config file
  • an upgrade from a version using the .json config file

In every scenario, the result must be centroen_vmware running on the .json file and no .pm file must remain.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@omercier omercier added do-not-spellcheck avoid running the spellchecks in github action upload-artifacts labels Nov 18, 2024
@omercier omercier force-pushed the CTOR-1079-Switch-centreon-vmware-daemon-from-pm-to-JSON-config-file branch from a0a3609 to 020970c Compare November 18, 2024 16:15
@omercier
fix(packaging): various issues + migration to JSON config file
a5f0f36 
- missing dependency on AlmaLinux
- /etc/(default|sysconfig)/centreon_vmware was ignored
- migrate the config file from .pm to .json
@omercier omercier force-pushed the CTOR-1079-Switch-centreon-vmware-daemon-from-pm-to-JSON-config-file branch from 020970c to a5f0f36 Compare November 18, 2024 16:20
@omercier omercier marked this pull request as ready for review November 18, 2024 16:39
@omercier omercier requested review from a team as code owners November 18, 2024 16:39
@omercier omercier merged commit 1f9e3b4 into develop Nov 28, 2024
7 checks passed
@omercier omercier deleted the CTOR-1079-Switch-centreon-vmware-daemon-from-pm-to-JSON-config-file branch November 28, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdepassio sdepassio sdepassio approved these changes

@kabreu kabreu kabreu approved these changes

@paloth paloth Awaiting requested review from paloth paloth is a code owner automatically assigned from centreon/owners-bash

@Evan-Adam Evan-Adam Awaiting requested review from Evan-Adam Evan-Adam is a code owner automatically assigned from centreon/owners-perl

Assignees
No one assigned
Labels
do-not-spellcheck avoid running the spellchecks in github action upload-artifacts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omercier @kabreu @sdepassio