Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional_tests/test_current_fillament.py does not actually test y-directed fillament #7

Open
brickZA opened this issue Jul 25, 2011 · 3 comments
Assignees

Comments

@brickZA
Copy link
Member

brickZA commented Jul 25, 2011

See lines:

    self.assertTrue(err_z < 4.7)      
    self.assertTrue(err_x < 4.7)      
    self.assertTrue(err_z < 4.7)      

Last one should be err_y. If changed, the test fails. There is probably something wrong with the rotation of the reference result.

@elezar
Copy link
Contributor

elezar commented Jul 26, 2011

In this case, should we edit the source, and then create a new issue for the failing test?

@brickZA
Copy link
Member Author

brickZA commented Jul 26, 2011

On Tue, Jul 26, 2011 at 3:27 AM, elezar
reply@reply.github.com
wrote:

In this case, should we edit the source, and then create a new issue for the failing test?

I think we should do this all in one. I should probably do it, since I
know what the test is supposed to do! So I'll assign this to myself,
and do it later.

Reply to this email directly or view it on GitHub:
#7 (comment)

@elezar
Copy link
Contributor

elezar commented Jul 26, 2011

I was hoping that you would say that :)

www.evanlezar.com

GoogleTalk: evanlezar
Skype: evanlezar

On Tue, Jul 26, 2011 at 2:02 PM, brickZA <
reply@reply.github.com>wrote:

On Tue, Jul 26, 2011 at 3:27 AM, elezar
reply@reply.github.com
wrote:

In this case, should we edit the source, and then create a new issue for
the failing test?

I think we should do this all in one. I should probably do it, since I
know what the test is supposed to do! So I'll assign this to myself,
and do it later.

Reply to this email directly or view it on GitHub:
#7 (comment)

Reply to this email directly or view it on GitHub:
#7 (comment)

@ghost ghost assigned brickZA Jul 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants