-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quickstart: wait for psql to start & expose argo ui #345
base: main
Are you sure you want to change the base?
Conversation
szab100
commented
Jul 13, 2022
•
edited
Loading
edited
- On slower k8s clusters, waiting until the postgresql pod becomes ready is not enough, we need to wait until it can serve requests instead, otherwise db creation and the db_migration job fails.
- Expose the Argo (web) UI on http://localhost:2746/ (with no authentication required) for better observability of cello workflows.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 69.63% 69.63%
=======================================
Files 11 11
Lines 2052 2052
=======================================
Hits 1429 1429
Misses 521 521
Partials 102 102 Continue to review full report at Codecov.
|
@grantleehoffman @jk-intuit Can we create a build job (or extend the current one) that builds these two docker images { |
@@ -109,6 +114,14 @@ set -e | |||
# don't fail if already exists | |||
set +e | |||
export POSTGRES_POD="$(kubectl get pods --no-headers -o custom-columns=":metadata.name" | grep postgres)" | |||
|
|||
RETRIES=20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: a better solution for this would be to add proper readiness/liveness probes to the postgres deployment
392f867
to
40ef4c0
Compare
91b6a65
to
1808b3c
Compare
7c24cfc
to
44c4924
Compare