Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstart: wait for psql to start & expose argo ui #345

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

szab100
Copy link
Contributor

@szab100 szab100 commented Jul 13, 2022

  1. On slower k8s clusters, waiting until the postgresql pod becomes ready is not enough, we need to wait until it can serve requests instead, otherwise db creation and the db_migration job fails.
  2. Expose the Argo (web) UI on http://localhost:2746/ (with no authentication required) for better observability of cello workflows.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #345 (e799d12) into main (5de3347) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   69.63%   69.63%           
=======================================
  Files          11       11           
  Lines        2052     2052           
=======================================
  Hits         1429     1429           
  Misses        521      521           
  Partials      102      102           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5de3347...e799d12. Read the comment docs.

@szab100 szab100 changed the title quickstart: wait until psql is ready to serve reqs quickstart: wait for psql to start & expose argo ui Jul 13, 2022
@szab100
Copy link
Contributor Author

szab100 commented Jul 13, 2022

@grantleehoffman @jk-intuit Can we create a build job (or extend the current one) that builds these two docker images {cello, cello-db-migration} and pushes them to ghcr.io with version + latest tags and set the imagePullPolicy to Always in the manifests? So that the quickstart stack can start up quicker, become more stable and drop the docker requirement?

@@ -109,6 +114,14 @@ set -e
# don't fail if already exists
set +e
export POSTGRES_POD="$(kubectl get pods --no-headers -o custom-columns=":metadata.name" | grep postgres)"

RETRIES=20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: a better solution for this would be to add proper readiness/liveness probes to the postgres deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants