share: NewShare should return value instead of pointer

[Wondertan]

There is literally no value in returning a pointer in this case. The Share struct is smaller and has only one ptr field data , leading to copying the value instead of pointer indirection having better performance. Also, working with a pointer is slightly more annoying.

Refs:

• https://dev.to/anubhav023/go-benchmarks-does-pass-by-pointer-really-make-a-difference-1540
• https://blog.devtrovert.com/p/go-ep3-pass-values-not-pointers