Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs: Specify node types #1862

Open
rootulp opened this issue Mar 3, 2023 · 2 comments
Open

specs: Specify node types #1862

rootulp opened this issue Mar 3, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@rootulp
Copy link
Contributor

rootulp commented Mar 3, 2023

Context

https://github.com/celestiaorg/celestia-specs was deprecated in favor of specs per repo. See celestiaorg/celestia-specs#212

Problem

celestia-node doesn't have a specs directory yet.

Proposal

When we create a specs/ directory in this repo, we may draw inspiration from node_types.md. Additionally we should explain under what conditions a celestia-node should halt. Motivated by celestiaorg/celestia-app#1436 (comment)

@rootulp rootulp added the documentation Improvements or additions to documentation label Mar 3, 2023
@ramin ramin closed this as completed Dec 13, 2023
@rootulp rootulp reopened this Feb 15, 2024
@rootulp
Copy link
Contributor Author

rootulp commented Feb 15, 2024

Re-opening because celestia-node is getting it's own specs soon (#3186) so this issue became relevant again.

@Wondertan Wondertan changed the title docs: Consider creating a specs/ directory specs: Specify node types Feb 15, 2024
@Wondertan
Copy link
Member

Changing this issue to track the node type specification from general "Consider creating specs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants