Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider hard-coding v2 upgrade heights #3995

Open
rootulp opened this issue Oct 21, 2024 · 2 comments
Open

Consider hard-coding v2 upgrade heights #3995

rootulp opened this issue Oct 21, 2024 · 2 comments
Labels
enhancement New feature or request WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 21, 2024

Context

We used a --v2-upgrade-height flag on networks

Problem

If a consensus node is block syncing from genesis, it needs to provide the --v2-upgrade-height

Proposal

Consider hard-coding the --v2-upgrade-heights for arabica, mocha, mainnet beta so that node operators don't have to specify it.

@rootulp rootulp added the enhancement New feature or request label Oct 21, 2024
@cmwaters
Copy link
Contributor

I am for this

@evan-forbes evan-forbes added the WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc label Nov 8, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 27, 2024

Note: this will be cumbersome to test b/c we'll need to block sync on Arabica, Mocha, or Mainnet through the v2 upgrade height.

To make this issue easier, we should build a utility that makes it easier + faster to block sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Development

No branches or pull requests

3 participants