Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default mempool max tx bytes past 8MB #3974

Open
rootulp opened this issue Oct 15, 2024 · 1 comment
Open

Update the default mempool max tx bytes past 8MB #3974

rootulp opened this issue Oct 15, 2024 · 1 comment

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 15, 2024

          Can we have an issue to bump this value past 8MB

Originally posted by @cmwaters in #3961 (comment)

@evan-forbes evan-forbes changed the title Can we have an issue to bump this value past 8MB Update the default mempool max tx bytes past 8MB Nov 11, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 27, 2024

For context celestia-app overrides the defaults:

	cfg.Mempool.MaxTxBytes = 7_897_088
	cfg.Mempool.MaxTxsBytes = 39_485_440

7_897_088 bytes is 7.5 MiB. Given Arabica will support 8 MiB blocks soon, it seems prudent to increase the default MaxTxBytes to something larger than 8 MiB so that the mempool has more capacity than a single block. If we don't update the default, we may end up in scenarios where a block gets produced with all the transactions from the mempool and then nothing is included in subsequent blocks because the mempool is empty. In order to action this issue we should:

  1. Investigate the downsides of increasing this value
  2. Investigate what other chains set this value to
  3. Propose candidate values based on the above
  4. Get alignment from team, then update the default
  5. [Optional] ask Arabica node operators to modify the value in their local config

Related: #3928 and #2686 and #3966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant