Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change square size in testapp #3971

Open
rach-id opened this issue Oct 14, 2024 · 1 comment
Open

change square size in testapp #3971

rach-id opened this issue Oct 14, 2024 · 1 comment
Assignees
@rach-id
Labels
testapp directly relevant to testapp usage

Comments

@rach-id
Copy link
Member

rach-id commented Oct 14, 2024 

          if we just want to change the square size, we can in theory use https://github.com/celestiaorg/celestia-app/blob/3ea0ca5bd589d7212dbd429eaca8365ff2f35dc9/test/util/genesis/modifier.go#L24-L32

however testapp doesn't support this yet. I'm okay with opening an issue to fix tmrw or the day after

Originally posted by @evan-forbes in #3942 (comment)
@rach-id rach-id self-assigned this Oct 14, 2024
@rach-id rach-id changed the title if we just want to change the square size, we can in theory use https://github.com/celestiaorg/celestia-app/blob/3ea0ca5bd589d7212dbd429eaca8365ff2f35dc9/test/util/genesis/modifier.go#L24-L32 change square size in testapp Oct 14, 2024
@rach-id rach-id added testapp directly relevant to testapp usage and removed needs:triage labels Oct 14, 2024
@rach-id rach-id mentioned this issue Oct 14, 2024
Merged
@rach-id
Copy link
Member Author

rach-id commented Oct 14, 2024

also this #3942 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
testapp directly relevant to testapp usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rach-id