You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What's the expected behavior for calling then() on a resolved promise? Right now you add callbacks that will never get called.
E.g. using an EagerResult in celery you end up with something like this:
val=40result=EagerResult(val)
# Internally result.on_ready is a promise that has already fired, e.g. promise(val) is called.result.then(callback, errback)
# Neither of these will ever fire.
I'd expect adding a callback to an already resolved promise to call it immediately.
Note that Twisted will immediately run your callbacks if a Deferred already has resolved, so I'm expecting the same behavior here.
(As an aside -- I find it odd you can resolve a promise multiple times...but it doesn't seem to have the same callback chain.)
The text was updated successfully, but these errors were encountered:
My thought is that it is confusing that the callbacks never get called, but it is unclear what should happen. This package sadly lacks any documentation of the expected behaviors.
What's the expected behavior for calling
then()
on a resolved promise? Right now you add callbacks that will never get called.E.g. using an
EagerResult
in celery you end up with something like this:I'd expect adding a callback to an already resolved promise to call it immediately.
Note that Twisted will immediately run your callbacks if a
Deferred
already has resolved, so I'm expecting the same behavior here.(As an aside -- I find it odd you can resolve a promise multiple times...but it doesn't seem to have the same callback chain.)
The text was updated successfully, but these errors were encountered: