Allow user_presence param in AuthenticatorResponse#verify to override silent_authentication config
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of `verify` for different values of `silent_authentication`
…de `silent_authentication` config
…ifferent values of `user_presence`
| @@ -35,7 +35,8 @@ def verify(expected_challenge, expected_origin = nil, user_presence: true, user_ | |||
| verify_item(:authenticator_data) | |||
| verify_item(:rp_id, rp_id || rp_id_from_origin(expected_origin)) | |||
|
|
|||
| if !relying_party.silent_authentication && user_presence | |||
| user_presence = !relying_party.silent_authentication if user_presence.nil? | |||
There was a problem hiding this comment.
I think I would do:
# Fallback to RP configuration unless user_presence is passed in explicitely
if user_presence.nil? && !relying_party.silent_authentication || user_presence
There was a problem hiding this comment.
Updated in 74daca7!
brauliomartinezlm
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Great work @santiagorodriguez96 👏
Thank you for handling this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #432 was merged it is possible to call
AuthenticatorResponse#verifywithuser_presencebeingtruewhile having enabledsilent_authenticationfor the Relying Party and the method would not verify user presence which it can be confusing for users.Details
This PR changes this behavior so that the
user_presenceparam, when passed, will always override thesilent_authenticationconfig.