Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing testing.* UI colour definition result in illegible test coverage results #456

Open
dylan-robins opened this issue Nov 11, 2024 · 0 comments · May be fixed by #458
Open

Missing testing.* UI colour definition result in illegible test coverage results #456

dylan-robins opened this issue Nov 11, 2024 · 0 comments · May be fixed by #458
Labels
enhancement New feature or request

Comments

@dylan-robins
Copy link

I just started using the catppuccin theme in vscode, and immediately I noticed a significant difference between this and the jetbrains version of the theme: I can't tell the difference between tested and untested code when using the (new?) visualization provided by vscode!!

Here's what the mocha flavour looks like currently in vscode. I'll only include screenshots of mocha, but the issue is present in all four flavours :
image

As you can see, very little difference between the lines highlighted in green and those highlighted in red. Now also take into account that I (like 4% of the population) am red/green colourblind... Yeah. Not great. I don't have my access to my works PC with my pycharm license right now to take a screenshot, but I can guarantee that the contrast is a lot better.

Now I found that I can override the UI colours on my side using my settings.json, but IMO the defaults need to be changed to something along these lines because the current colours are just silly.

    "catppuccin.customUIColors": {
        "mocha": {
            "testing.coveredBackground": "green 0.3",
            "testing.coveredGutterBackground": "green 0.3",
            "testing.uncoveredBackground": "red 0.3",
            "testing.uncoveredGutterBackground": "red 0.3"
        },
    }

That results in something much more similar to what I have in pycharm:
image

BUT, this throws a warning because these keys aren't specified in the json schema. I guess these keys were added in a recent version of vscode and this theme hasn't been updated..? In any case they are documented here: https://code.visualstudio.com/api/references/theme-color#testing-colors

I can open a PR proposing a fix if you want. Let me know what you think! ☕️🐈

@sgoudham sgoudham added the enhancement New feature or request label Nov 15, 2024
@dylan-robins dylan-robins linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants