Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect calculation of the container height in the case of dynamic rendering of table rows #218

Open
Zveroboev opened this issue Sep 13, 2018 · 4 comments

Comments

@Zveroboev
Copy link

Zveroboev commented Sep 13, 2018

In this issue shows an example of how to use the RectList in table rendering (#47)

In the current implementation does not take into account the height of the <thead> tag that is not included in the items array

Real container height:
image

Сalculated container height
image

@Zveroboev
Copy link
Author

ping

@aih8
Copy link

aih8 commented Feb 12, 2019

@Zveroboev have find a way to fix this ? I met the same question

@Zveroboev
Copy link
Author

@aih8 no :(

@Venryx
Copy link

Venryx commented Oct 30, 2019

Found a way to fix it -- as long as the header's height is constant.

Just add margin-bottom: ?px; to the styling of the root div element that ReactList's render function generates.

I currently do this by using a css selector as follows:

.parent-containing-react-list > div:nth-child(INDEX_OF_REACT_LIST_CHILD) {
  margin-bottom: ?px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants