Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in @shopify/cli-kit@3.40.0 #17

Open
dylansmith opened this issue Mar 2, 2023 · 3 comments
Open

Breaking changes in @shopify/cli-kit@3.40.0 #17

dylansmith opened this issue Mar 2, 2023 · 3 comments

Comments

@dylansmith
Copy link

Firstly, thanks for this fantastic template. However, there are some breaking changes to the structure of the @shopify/cli-kit package introduced in it's 3.40.0 (minor?) version which are preventing the app from starting for npm users (since you only have a pnpm-lock.yml in the template).

error - Failed to load next.config.mjs, see more info here https://nextjs.org/docs/messages/next-config-error
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/REDACTED/shopify-node-app-starter/node_modules/@shopify/cli-kit/dist/index.js' imported from /Users/REDACTED/shopify-node-app-starter/next.config.mjs
    at new NodeError (node:internal/errors:387:5)
    at finalizeResolution (node:internal/modules/esm/resolve:330:11)
    at moduleResolve (node:internal/modules/esm/resolve:907:10)
    at defaultResolve (node:internal/modules/esm/resolve:1115:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:841:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40)
    at link (node:internal/modules/esm/module_job:75:36) {
  code: 'ERR_MODULE_NOT_FOUND'

My workaround was simply to specify the 3.13.0 version locally, but hopefully this issue will help others in a similar situation.

@swizzmagik
Copy link

swizzmagik commented Apr 16, 2023

I ran into the same issue and this workaround fixed it for me.

@arabovs
Copy link

arabovs commented Jun 14, 2023

likewise, appreciate all your work !

@mayankpal100dpanda
Copy link

Use "@shopify/cli-kit": "3.13.1", just you need to remove ^ from cli-kit and Run npm i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants