Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an S3FileSystemConfiguration #195

Open
6 tasks
carlspring opened this issue Feb 1, 2021 · 0 comments
Open
6 tasks

Implement an S3FileSystemConfiguration #195

carlspring opened this issue Feb 1, 2021 · 0 comments
Assignees

Comments

@carlspring
Copy link
Owner

carlspring commented Feb 1, 2021

Task Description

The current implementation of the configuration is not flexible enough. It also requires you to pass properties around. The way that the properties are loaded for testing and production is different. We should implement a S3FileSystemConfiguration and use this instead of the properties/hash maps.

Tasks

The following tasks will need to be carried out:

  • Create an S3FileSystemConfiguration and add all the meaningful property keys as fields in this class.
  • Implement a from(Map<String, ?> map) constructor.
  • Implement a from(Properties properties) constructor.
  • Implement a public Map<String, String> asMap().
  • Implement a public Properties asProperties().
  • Implement a getBaseURI() method that is a representation of the current bucket for which this configuration is.

Task Relationships

This task:

Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant