Works by checking for each ticket if the corresponding event has passed

Make Event.Start/End DateTime?
careerfairsystems · Apr 26, 2024 · d6c879f · d6c879f
1 parent 3800cff
commit d6c879f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/Nexpo.Tests/Controllers/TicketsControllerTest.cs b/Nexpo.Tests/Controllers/TicketsControllerTest.cs
@@ -1103,18 +1103,18 @@ public async Task sendTicketViaEmailSeveralTicketsNonLoggedIn(){
         [Fact]
         public async Task TooManyTickets()
         {
-            // Student2 already has 5 tickets
+            // Student2 already has 5 tickets but not -7
             var client = await TestUtils.Login("student2");
             var json = new JsonObject
             {
-                { "eventid", -2 },
+                { "eventid", -7 },
                 { "photook", true }
             };
             var payload = new StringContent(json.ToString(), Encoding.UTF8, "application/json");
             var response = await client.PostAsync("api/tickets", payload);
             // Verify response - Conflict because the student already has a ticket for the event
             Assert.True(response.StatusCode.Equals(HttpStatusCode.TooManyRequests),
-                "Wrong status code. Expected: TooManyRequests. Received: " + response.ToString());
+                "Wrong status code. Expected: TooManyRequests. Received: " + response);
         }
     } 
 }
diff --git a/Nexpo/Controllers/Events/TicketsController.cs b/Nexpo/Controllers/Events/TicketsController.cs
@@ -75,9 +75,23 @@ public async Task<ActionResult> PostTicket(CreateTicketDTO DTO)
             }
 
             // Check for max number of registrations
-            int max = 5;
-            int noTickets = (await _ticketRepo.GetAllForUser(userId)).Count();
-            if (noTickets  >= max)
+            int maxNoTickets = 5;
+            // Assmues no event found or faulty format of date should not be counted
+            int noTickets = (await _ticketRepo.GetAllForUser(userId)).Count(ticket =>
+                {
+                    var foundEvent = _eventRepo.Get(ticket.EventId);
+                    if (foundEvent.Result == null)
+                    {
+                        return false;
+                    }
+                    bool isSuccess = DateTime.TryParse(foundEvent.Result.Start, out var eventDateTime);
+                    if (isSuccess)
+                    {
+                        return eventDateTime > DateTime.Now;
+                    }
+                    return false;
+                });
+            if (noTickets  >= maxNoTickets)
             {
                 return StatusCode(429, "Too many tickets");
             }