Merge pull request #102 from cardano-foundation/feature/MET-2208-erro…

…r-while-using-self-hosted-sanchonet-instance fix: null pointer ex when poolFetchList from koios is empty
cardano-foundation · Jul 2, 2024 · b21cc2d · b21cc2d
2 parents c23af4d + 671d0b6
commit b21cc2d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/...ain/java/org/cardanofoundation/explorer/rewards/schedule/service/PoolInfoDataService.java b/...ain/java/org/cardanofoundation/explorer/rewards/schedule/service/PoolInfoDataService.java
@@ -16,6 +16,7 @@
 import org.springframework.scheduling.annotation.Async;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
+import org.springframework.util.CollectionUtils;
 
 import io.micrometer.common.util.StringUtils;
 import rest.koios.client.backend.api.base.exception.ApiException;
@@ -49,6 +50,10 @@ public CompletableFuture<Boolean> fetchData(List<String> poolIds) {
     int currentEpoch = epochService.getCurrentEpoch();
     var dataFromKoios = getPoolInfoList(poolIds);
 
+    if (CollectionUtils.isEmpty(dataFromKoios)) {
+      return CompletableFuture.completedFuture(Boolean.TRUE);
+    }
+
     var poolHashMap =
         poolHashRepository.findByViewIn(poolIds).stream()
             .collect(Collectors.toMap(PoolHash::getView, Function.identity()));

diff --git a/...a/org/cardanofoundation/explorer/rewards/service/impl/PoolHistoryFetchingServiceImpl.java b/...a/org/cardanofoundation/explorer/rewards/service/impl/PoolHistoryFetchingServiceImpl.java
@@ -17,6 +17,7 @@
 import org.springframework.scheduling.annotation.Async;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
+import org.springframework.util.CollectionUtils;
 
 import io.micrometer.common.util.StringUtils;
 import rest.koios.client.backend.api.base.exception.ApiException;
@@ -60,6 +61,10 @@ public CompletableFuture<Boolean> fetchData(String poolId) {
     var dataFromKoios = getPoolHistoryList(poolId);
     var poolHistoryCheckpoint = poolHistoryCheckpointRepository.findByView(poolId);
 
+    if (CollectionUtils.isEmpty(dataFromKoios)) {
+      return CompletableFuture.completedFuture(Boolean.TRUE);
+    }
+
     Map<Integer, PoolHistory> poolHistoryList =
         dataFromKoios.stream()
             .filter(poolHistory -> poolHistory.getEpochNo() < currentEpoch)