-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0010 | Add 10297 label for fida.finance #906
Conversation
@ssledz - Would you please edit your submission so the metadata number is sorted in correct numerical order with the other submissions and correct the mismatch in indentation? @Ryun1 @Crypto2099 @perturbing certainly this looks justified: https://medium.com/@fida.finance/democratizing-the-insurance-industry-through-blockchain-990700fd438f ... but maybe we should wait to ensure the request is properly formatted before enabling the new GitHub CI processing of CIP-0010 additions. I'm not sure if it checks for proper numerical order and/or sorts them (cc @Godspeed-exe from #837). |
@rphair my workflow does not check for sorting / do sorting. |
@rphair, my view of this CIP is that currently any project can claim a label number. So with that, I think this PR indeed looks justified by your above link. That said, I do wonder how this will pan out in the future, as there is no clear guideline. Furthermore, currently labels are forever, are all registered labels still actively used? These two things might cause some issues in the future, where we as CIP editors do not have clear guidance. |
Yes @perturbing - I agree on all of that & think that CIP-0010 might benefit from an update with whatever clarification might be necessary as project tag requests start coming in again. One more issue is the human factor that, because of their sorted arrangement, these aren't just cardinal numbers as the CIP indicates but are also perceived as ordinal numbers. This has the interesting consequence that those apparently taking advantage of that ordinality will also be the least likely to acknowledge it: ... so perhaps this dialogue could also be considered in a CIP-0010 update that provides guidelines to establish project significance in numbering, as well as proof of legitimacy. @ssledz this is just a side discussion to your submission & rest assured we will enable the GitHub CI workflow on this PR as soon as you clean up your edited file as requested. |
Just a little brainstorm :)
2). We could hash (even with a VRF if needed for proper randomness), their PR, and modulo reduce it to fit in the range and have that as their number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssledz I've done the edits that we asked you to do and @Ryun1 will open up issues for the general questions that have come up here.
@perturbing @Crypto2099 apparently this edit has triggered the GitHub CI and it looks like it's passed already. This is ready for merge but since it's our first CI workflow run for the CIP-0010 structure I guess we should check those workflow logs. 🤔
Issue to continue discussions! |
@rphair thanks for handling this I have just missed this pr & conversation in the rush of tasks 😅 |
No description provided.