-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0121? | Integer-ByteString conversions #624
CIP-0121? | Integer-ByteString conversions #624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kozross for a well documented submission. First I'm retitling this by convention the same as the current document title (Integer-ByteString conversions) especially since the more succinct title will work better in our CIP list once merged.
The main item I believe needs to be fixed (or checked at least) are the CIP-0035 requirements for builtin changes. Though different language is used, I think the general requirements are satisfied: https://github.com/cardano-foundation/CIPs/blob/master/CIP-0035/README.md#processes
... but not all the particular requirements: https://github.com/cardano-foundation/CIPs/blob/master/CIP-0035/README.md#additions-to-the-plutus-core-builtins
@michaelpj any time you can look over this submission I would really appreciate it. If I'm wrong about this not meeting the particular specifications for builtins by CIP-0035 I would happily stand corrected. To me this looks ready for acceptance as soon as all the formalities are met.
87550dd
to
04b001e
Compare
@rphair Can we assign this a CIP number and merge it? Not only has it already been approved, but it has already been implemented and released in Plutus V3. |
@zliu41 my apologies for being under the impression that the currently debated #794 was relative to CIP-0058 alone; in fact this one had fallen through the cracks in the belief it was still waiting for input from Plutus reviewers. This PR branch is on an MLabs repository so I'll propose some changes there which @kozross can approve, to add a CIP number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kozross I'll also submit a PR against this branch to modify the README
for the CIP repository that officially assigns the CIP number (otherwise we wait for the 2-week meeting intervals).
@kozross this is likely to cause a merge conflict with the CIP repo's `master` branch; if so, just put your new CIP `121` after the merged CIP `120` and keep the more current modification date.
CIP-0121? | Update CIP number in main repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kozross look ready to merge from an editorial perspective, except for one artefact in the repo README
probably from rebasing or fixing a merge conflict; will approve this when that's fixed...
Co-authored-by: Robert Phair <rphair@cosd.com>
@Ryun1 @Crypto2099 I'm marking this as Likewise @michaelpj @zliu41 please let us know if any technical reservations. It seems to me everything above has been addressed & I would be in favour of merging these 2 related proposals before the meeting if the other editors agree. |
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kozross re: #624 (review) thanks for eaa2263 but there's still a merge conflict due the modification time on that section also being changed:
Co-authored-by: Robert Phair <rphair@cosd.com>
@zliu41 apologies for extra tags above... I fat fingered some GitHub feature while my Internet connection was bad. I understand you think this is ready to merge and FYI the editorial consensus from CIP meeting 2 days ago was that this is ready to go pending the administrative requirements that have recently been addressed. |
CIP for Plutus primops for converting
BuiltinInteger
toBuiltinByteString
, and back.Human-readable version.