-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken hyperlink in the documentation #972
Comments
@rakeshgowerneni that's a good catch! I'm curious why sphinx did not generate that properly. Thoughts on how to fix? We welcome PRs and would love to see you contribute! |
@rakeshgowerneni -- Check out our contribution guide here for creating pull requests. |
When you implement the fix @rakeshgowerneni, be sure its not specifying a specific version in the hyperlink. Rather, it should be agnostic to the version and just resolve to the proper location within whatever docs are live at that time.
|
Hey is anyone working on this? Can I try this out? |
Yes, you are more than welcome! README.md in the `dev-gh-pages` would be a
good place to start for building documentation. Thanks and let me know if
you have any other questions. Cheers!
|
@thebadcoder96 let me know if you have anymore questions -- the team is back at it today. Thanks for your interest! |
Thank you for the response! I will go through the readme file that you mentioned and let you know if I have any questions. |
Thanks @thebadcoder96! |
Here is how I think we can solve the issue. I do not have much idea on sphinx but I am looking into that as well.
Wdyt? Any other thoughts are welcome since I do not have full context on how everything works within the Data Profiler, I might be wrong as well. |
I think we can actually re-use the code written out here. That script will have:
That should work! For updating docs, all changes will happen on your fork's branch of |
Please correct me if I am wrong, but the issue mentioned here pertains to the readme file of the Data Profiler Github. In the documentation website there is no hyperlink and the sentence is also a bit different. From my understanding, |
@thebadcoder96 yes, you are correct. I was confusing something else. In this case I would key off of the |
@thebadcoder96 the URL should be
We'll want the version tag to be a reference and not a manual change every time we make a new release of dataprofiler. |
Since you mentioned version tag, I think we can use I have created a PR with the proposed changes, please review #1080 |
Please provide the issue you face regarding the documentation
The hyperlink in the below sentence in the
Load a File
section should change fromIf the file type is not automatically identified (rare), you can specify them specifically, see section Specifying a Filetype or Delimiter.
to
If the file type is not automatically identified (rare), you can specify them specifically, see section Specifying a Filetype or Delimiter.
I am trying to fix the documentation as a way to create my first PR on the repo.
The text was updated successfully, but these errors were encountered: