Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-ACK after a set time period #22

Closed
eslerm opened this issue May 26, 2023 · 3 comments · Fixed by #56
Closed

re-ACK after a set time period #22

eslerm opened this issue May 26, 2023 · 3 comments · Fixed by #56
Labels
wontfix This will not be worked on

Comments

@eslerm
Copy link
Member

eslerm commented May 26, 2023

When there is a long gap between ACK to main and promotion to main, the MIR Team and Security Team should have an opportunity to re-investigate a MIR.

I'm unsure where this rule should go. I propose that re-ACK is required for any ACK older than an LTS cycle:

An ACK from the MIR Team or Security Team which is older than two years must be re-acknowledged before promotion to main. The MIR Team or Security Team may choose to simply re-ACK or re-investigate the MIR.

@eslerm
Copy link
Member Author

eslerm commented Nov 10, 2023

I may have not stated this well enough: this issue is about a package which has been conditionally approved by the MIR (and possibly Security) team, but incomplete and not yet in main. After a long period, say two-years, I believe the MIR needs to be re-reviewed for promotion in main even if the owning team resolves outstanding issues.

This type of promotion happened during lunar.

@cpaelzer cpaelzer added the wontfix This will not be worked on label May 28, 2024
@cpaelzer
Copy link
Collaborator

For now, no one was willing or able to spend the extra resources - tagging it as won't fix until that changes

@eslerm
Copy link
Member Author

eslerm commented May 28, 2024

We discussed this during today's meeting. The intent of this issue is to allow re-triaging MIR approvals which have gone "stale". After two years, if the owning team has not promoted a package after getting ACK, the MIR team should have the option to re-review the package again.

This is not about reviewing packages already in main like #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants