Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rockraft file of mlserver-sklearn for CKF 1.8 #53

Closed
Tracked by #224
kimwnasptd opened this issue Nov 20, 2023 · 2 comments · Fixed by #72
Closed
Tracked by #224

Update rockraft file of mlserver-sklearn for CKF 1.8 #53

kimwnasptd opened this issue Nov 20, 2023 · 2 comments · Fixed by #72
Labels
enhancement New feature or request

Comments

@kimwnasptd
Copy link
Contributor

What needs to get done

Update the corresponding rockcraft.yaml file to make sure the version of CKF 1.8 is built.

DoD:

  • The rockcraft.yaml is updated
  • There is automation that builds the image in each PR
  • There is automation that pushes the image, once a PR is merged

Why it needs to get done

To make sure we have less CVEs in 1.8 than upstream, and enable us to be able to potentially create patches for package versions in the future
@kimwnasptd kimwnasptd added the enhancement New feature or request label Nov 20, 2023
@kimwnasptd kimwnasptd mentioned this issue Nov 20, 2023
Closed
6 tasks
@kimwnasptd kimwnasptd reopened this Nov 20, 2023
@orfeas-k orfeas-k mentioned this issue Dec 13, 2023
Merged
@orfeas-k
Copy link
Contributor

Added a comment in #70 plus some general details in #37.

@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5140.

This message was autogenerated

orfeas-k added a commit that referenced this issue Jan 11, 2024
@orfeas-k
chore: bump mlserver-sklearn for Seldon version 1.15.x -> 1.17.1 (#72)
959da10 
Update ROCK according to upstream changes plus:
- introduce parts that we missed in the ROCK
- use ubuntu 20.04 as base due to #39
- refactor tox.ini according to canonical/oidc-authservice-rock#14 and canonical/bundle-kubeflow#763
- update `test_rock.py` according to latest changes in chisme canonical/charmed-kubeflow-chisme#81
- pins starlette due to #80

Ref #37
Closes #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump mlserver-sklearn for Seldon version 1.15.x -> 1.17.1 canonical/seldonio-rocks
2 participants
@kimwnasptd @orfeas-k