Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TODO to an avoidance list as a warning #78

Open
izmalk opened this issue Aug 16, 2024 · 3 comments
Open

Add TODO to an avoidance list as a warning #78

izmalk opened this issue Aug 16, 2024 · 3 comments

Comments

@izmalk
Copy link
Contributor

izmalk commented Aug 16, 2024

Add a ToDo comment to a list of avoided terms with a warning.
It should be case-insensitive (to cover all the variants: todo, TODO, ToDo).

@ru-fu
Copy link
Contributor

ru-fu commented Aug 19, 2024

Let's call that an ignore list or something. ;)

@izmalk izmalk changed the title Add TODO to a blacklist as a warning Add TODO to an avoidance list as a warning Aug 19, 2024
@izmalk
Copy link
Contributor Author

izmalk commented Oct 14, 2024

Let's call that an ignore list or something. ;)

Actually, we should avoid using TODO in the docs (or at least highlight it as a potential error upon testing).
We should not ignore it (at least automatically, like the vale tests).
We can think of an alternative, for example, block list, reject list, or triggers.
P.S. The idea is not exactly to ban usage of TODO at all, but rather make it more visible so we won't forget about it.

@SecondSkoll
Copy link
Contributor

I think this is a good idea, with a caveat or two. I think if you have a "TODO" in your documentation it should be a known issue which requires work to be done. If a Jira issue has been created for the work to be done, then I think the TODO should be ignored automatically.

So some specific implementation of TODO: [JIRA-1234] <details> could be ignored, but other cases would raise errors.

This would mean any usage of "TODO" would either have a linked issue which requires work or raise an error - which would mean it could be easily noticed or tracked.

Thinking about general implementation of this rule (as I hope that we'll be able to provide our Vale style as a Vale package at some point) I think this rule should default to a suggestion, but then be overwritten by our vale.ini as is being suggested in #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants