Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

referring to GH issues in NEWS #227

Open
jaganmn opened this issue Oct 18, 2024 · 3 comments
Open

referring to GH issues in NEWS #227

jaganmn opened this issue Oct 18, 2024 · 3 comments

Comments

@jaganmn
Copy link
Collaborator

jaganmn commented Oct 18, 2024

I mentioned in the call yesterday: FWIW, if you ever decide to change to inst/NEWS.Rd from NEWS.md, then you can use something like

\newcommand{\GH}{\href{https://github.com/canmod/macpan2/issues/#1}{GH##1}}
\section{Changes in version 1.10.0 (2024-10-18)}{
  \subsection{New Features}{
    \item Change log moved from \file{NEWS.md} to \file{inst/NEWS.Rd}, fixing \GH{227}.
  }
}

to refer to GitHub issues when listing new features and bug fixes. I don't know if Markdown supports something similar. Well, however you do it, linking the change log to the bug tracker is generally very helpful for maintainers and users alike.

I can create a pull request if you decide that you are open to using Rd markup for the change log.

@bbolker
Copy link
Collaborator

bbolker commented Oct 18, 2024

Markdown doesn't support macros (in general; there may be some dialects/flavours that do). You could of course spell out the references as GH1 (i.e. [GH1](https://github.com/canmod/macpan2/issues/#1), although obviously the \GH{} macro is easier to compose and read.

@jaganmn
Copy link
Collaborator Author

jaganmn commented Oct 18, 2024

I think issues/<number> will redirect to pull/<number> if <number> actually refers to a pull request (and vice versa). I don't remember if R CMD check complains about redirects. If it does, then you could always define a second macro (named, e.g., \PR) for pull requests.

@stevencarlislewalker
Copy link
Member

Thanks @jaganmn. I'll consider switching to Rd. I feel that the root cause of the issue is more about my thinking speed than typing speed. I should first get better at isolating feature requests and bug fixes, and then stuff like the above will feel more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants