Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using core_models.Gene in search response #251

Open
korikuzma opened this issue Sep 12, 2023 · 6 comments
Open

Consider using core_models.Gene in search response #251

korikuzma opened this issue Sep 12, 2023 · 6 comments
Labels
enhancement New feature or request priority:low Low priority

Comments

@korikuzma
Copy link
Member

I think it's kind of odd that we are using a custom gene pydantic class in search response but the ga4gh core pydantic class in another response. If there's not a (good) reason why we're doing this, I am strongly in favor of using the core class.

@korikuzma
Copy link
Member Author

Maybe it's because the core in 1.x.x did not support the additional metadata fields (extensions, label, etc) as we do now

@jsstevenson
Copy link
Member

I think (?) this would mean that we wouldn't need to retain a different between xref and associated_with, also, which simplifies data storage a bit

@jsstevenson
Copy link
Member

When this issue happens, I think we should revisit the structure and naming of the various Gene schema elements as they exist, and trim where appropriate

@jsstevenson
Copy link
Member

jsstevenson commented Dec 13, 2023

^ on that note, it appears that because Genes require symbols, a bunch of lncrna/pseudogene sorta objects in Ensembl are getting skipped (this may or may not be fine).

@jsstevenson
Copy link
Member

Copy link

This issue is stale because it has been open 180 days with no activity. This issue will be closed if no further activity occurs in 14 days.

@github-actions github-actions bot added the stale label Jul 17, 2024
@korikuzma korikuzma added enhancement New feature or request and removed stale labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority
Projects
None yet
Development

No branches or pull requests

2 participants