-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using core_models.Gene in search response #251
Comments
Maybe it's because the core in 1.x.x did not support the additional metadata fields (extensions, label, etc) as we do now |
I think (?) this would mean that we wouldn't need to retain a different between |
When this issue happens, I think we should revisit the structure and naming of the various Gene schema elements as they exist, and trim where appropriate |
^ on that note, it appears that because Genes require symbols, a bunch of lncrna/pseudogene sorta objects in Ensembl are getting skipped (this may or may not be fine). |
This issue is stale because it has been open 180 days with no activity. This issue will be closed if no further activity occurs in 14 days. |
I think it's kind of odd that we are using a custom gene pydantic class in search response but the ga4gh core pydantic class in another response. If there's not a (good) reason why we're doing this, I am strongly in favor of using the core class.
The text was updated successfully, but these errors were encountered: