Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add .railwayapp with default settings.yaml #176

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: add .railwayapp with default settings.yaml #176

wants to merge 2 commits into from

Conversation

antonleviathan
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@antonleviathan
Copy link
Contributor Author

Seems the best way to deal with this would be to maintain a branch called railway-app which has the .nostr/settings.yaml dir + file set up and an updated railway-app template, until we refactor the relay to use dynamic configs.

@cameri cameri mentioned this pull request Feb 10, 2023
Closed
@KiPSOFT
Copy link

KiPSOFT commented Feb 11, 2023

When the merge this pull request ?

@antonleviathan
Copy link
Contributor Author

@KiPSOFT it's not ready yet, I'm currently working on it. Should be ready by EOD.

@antonleviathan antonleviathan added the bug Something isn't working label Feb 11, 2023
@antonleviathan antonleviathan self-assigned this Feb 11, 2023
@antonleviathan antonleviathan marked this pull request as draft February 11, 2023 16:51
@antonleviathan
Copy link
Contributor Author

main...investinaccess:nostream:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameri cameri cameri approved these changes

Assignees

@antonleviathan antonleviathan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonleviathan @KiPSOFT @cameri