Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new function check devices config did not identical #130

Open
cynthiabour opened this issue May 22, 2024 · 5 comments
Open

new function check devices config did not identical #130

cynthiabour opened this issue May 22, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@cynthiabour
Copy link
Contributor

The current config file will still work if same address of two Elite11 was provide. It will be good to check config file before run

@JB-Wolf
Copy link
Collaborator

JB-Wolf commented May 22, 2024

If I remembe correctly, this should fail from the device side. In my opinion, this is also sufficient/fine. If the thing fails because of a user error, the thing fails. It is impossible to prevent all user errors. Eg the pump with address 0 needs to be connected via usb physically. This can not be checked via software, just by initializing. As long as an error is raised, IMHO this behaviour is fine

@cynthiabour
Copy link
Contributor Author

no. with the current method we have. it did not shows error. It might need more test.

@JB-Wolf
Copy link
Collaborator

JB-Wolf commented May 22, 2024

So it normally initialises? everything and leaves you quietly in the end without anything?
Then I agree, we need a check
Our PumpIO object could hold a daisy_chain object with pump_numbers already connected. This could be checked against when creating a certain pump. With this, later additions and even deletions on initialised code are possible, whereas checking the config file just prevents intial problems

@cynthiabour
Copy link
Contributor Author

yes and shows all devices connected. I only observed it once, so it need more investigation

@cynthiabour cynthiabour assigned JB-Wolf and unassigned cynthiabour May 23, 2024
@cynthiabour
Copy link
Contributor Author

Please also check with ml600 @JB-Wolf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants