Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2 overwrites parent method #115

Open
JB-Wolf opened this issue Jan 9, 2024 · 0 comments
Open

R2 overwrites parent method #115

JB-Wolf opened this issue Jan 9, 2024 · 0 comments
Assignees
@cynthiabour

Comments

@JB-Wolf
Copy link
Collaborator

JB-Wolf commented Jan 9, 2024

R2 Overwrites Valve method

Problem

set_position and get_position are redefined

Effect

  • Maintainability harder
  • affects behaviour uniformity

Solution

Device should just expose rule in _change_position (only device_component specific code part). Device level method is selected via hw_device attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cynthiabour cynthiabour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JB-Wolf @cynthiabour