Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform way of command scheduling #113

Open
JB-Wolf opened this issue Dec 18, 2023 · 1 comment
Open

Uniform way of command scheduling #113

JB-Wolf opened this issue Dec 18, 2023 · 1 comment

Comments

@JB-Wolf
Copy link
Collaborator

JB-Wolf commented Dec 18, 2023

Problem

Potentially, different devices react differently in some cases.

  • Some pumps allow for changing the flowrate when they are running, some might not
  • some pumps might throw error if one tries to start them while they are already running.

The impact of this is significant:

  • Errors might go undetected
  • devices are not exchangable

suggested solution

methods of abstract devices should only perform atomic operations

  • no bundling for easier use
  • throw error if state change is attempted while in dynamic state, e.g. change flowrate, start when running
@JB-Wolf
Copy link
Collaborator Author

JB-Wolf commented Dec 18, 2023

The abstract valve should "enforce" what a command looks like and implement throwing errors if this scheme is not followed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant