Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_sources -> data_tables & source -> data #688

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

brynpickering
Copy link
Member

Fixes #673

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (683a5b7) to head (a512239).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #688   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          26       26           
  Lines        3981     3981           
  Branches      837      768   -69     
=======================================
  Hits         3821     3821           
  Misses         70       70           
  Partials       90       90           
Files with missing lines Coverage Δ
src/calliope/model.py 96.29% <100.00%> (ø)
src/calliope/preprocess/data_tables.py 100.00% <100.00%> (ø)
src/calliope/preprocess/model_data.py 100.00% <100.00%> (ø)
src/calliope/util/schema.py 94.66% <100.00%> (ø)

Copy link
Contributor

@irm-codebase irm-codebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty simple refactoring. Approved!

Stuffy checked:

  • Checked the documentation/code for references to data_source
  • Checked the renamed classes / variables / functions.

@brynpickering brynpickering merged commit e447d17 into main Sep 30, 2024
13 checks passed
@brynpickering brynpickering deleted the data_sources-to-data_tables branch September 30, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming data_sources to avoid confusion
2 participants