feat: added insights badge to event-types #17762
Draft
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PeerRich
commented
Nov 20, 2024
•
PeerRich
commented
- query for total bookings, currently hard coded as 42
github-actions
bot
added
event-types
PeerRich
commented
Nov 20, 2024
| <li> | ||
| <Link href={`/insights?isAll=false&filter=event-type&eventTypeId=${eventType.id}`}> | ||
| <Badge variant="gray" startIcon="chart-bar"> | ||
| <p>{t("event_type_insights", { numberOfBookings: 42 })} </p> |
There was a problem hiding this comment.
TODO: query needed for total bookings
PeerRich
commented
Nov 20, 2024
| @@ -128,6 +130,13 @@ export const EventTypeDescription = ({ | |||
| </Badge> | |||
| </li> | |||
| ) : null} | |||
| <li> | |||
| <Link href={`/insights?isAll=false&filter=event-type&eventTypeId=${eventType.id}`}> | |||
There was a problem hiding this comment.
@eunjae-lee @sean-brydon this is currently not working consistently because the URL-param are borked. that PR needs to go live first
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (11/20/24)1 label was added to this PR based on Keith Williams's automation. |
…ton-to-link-to-insights-1
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.