Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project is not using a CSS convention #1

Open
romgrk opened this issue Jul 24, 2019 · 0 comments
Open

Project is not using a CSS convention #1

romgrk opened this issue Jul 24, 2019 · 0 comments

Comments

@romgrk
Copy link
Collaborator

romgrk commented Jul 24, 2019

There is no CSS convention in use, which leads to very particular selectors (illustrated below). Those selectors don't carry meaning, and it's hard to know what is being styled just by looking at the stylesheet.

Screenshot from 2019-07-24 12-42-48
(taken from the profile page)

For example, using the BEM convention, these would be written as:

.UserProfile__field {
 font-weight: 400;
}
.UserProfile__link {
 color: blue;
 /* ... */
}

The BEM convention helps avoid specificity issues and makes things more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant