Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#DocUpdate: Figure out a way to incorporate (updated Ref #37) README.md directly into RTD docs #38

Open
shaloo opened this issue Aug 27, 2019 · 4 comments
Assignees

Comments

@shaloo
Copy link
Collaborator

shaloo commented Aug 27, 2019

Based on feedback received via Rola

@shaloo shaloo self-assigned this Aug 27, 2019
@shaloo
Copy link
Collaborator Author

shaloo commented Aug 28, 2019

This can be achieved as follows:

  1. Incorporate Pipeline reference guide in RTD docs as .md (markdown) content instead of .rst (restructured text). Figure out a way to see if Sphinx can ingest both .rst and .md files as input. [Experiment done - possible] Step GCP Tutorial #1 Done.

  2. For remaining pipeline reference guide sections (RNA seq light, others pending) use md instead of .rst files. [RNA Seq Light - done, remaining 4 Pending]

  3. Experiment to see if .md files can be input from a different GitHub repo (GenPipes sources) directly - or at least have scripts to checkout/copy them at build time. [Done - see Makefile and confirm.py updates in #DocUpdate: Figure out a way to incorporate (updated Ref #37) README.md directly into RTD docs #38 checkins]

  4. Work with hector to see if these .md files can be reused directly in genpipes source code. [Pending]

  5. Once #DocUpdate - OpenDoor page under community needs work #4 is complete, remove the pipeline reference guide from sphinx c3g/genpipes RTD sources and ensure they are pulled at build time from genpipes sources directly. [Pending]

@shaloo
Copy link
Collaborator Author

shaloo commented Aug 29, 2019

There is a caveat. If we use markdown then we cannot have variable based content for automating things such as reading up version number from bitbucket tag and populating it in doc content at RTD during doc build time. That feature is supported in .rst (restructured text) format content only. Need to make a call if we really want to keep User Guide for Pipeline reference in md form. Here is what I would recommend:

  • We use rst file as that is more Sphinx and RTD friendly
  • If we need to keep content only in one place, then use an empty README.md file that has a link to published pipeline reference in RTD docs.

@pphector
Copy link
Member

Today I spent some time reading up on this issue to see if there is any way K\I could address point 4 outlined below. Previously, I prepared a special branch of GenPipes called read_the_docs (here). Essentially, the idea was to integrate the .md files to the GenPipes code as proposed by Shaloo. I was looking for ways to automate this directly in GitHub or Bitbucket, however it seems that this is not possible.

The best way I could come up with is inspired by this post. Essentially, it involves cloning the RTD repo locally, and using the git feature that allows for two remote repositories. The person doing the development would be able to do a commit twice so that the same commit updates both repositories...

This is a compromise. It is definitely not automated, and it does not allow changes that are made directly to a repository (in GitHub, for example) to be reflected in Bitbucket right away, without doing a pull, merge, and commit on a local copy. However, it is the only solution I could find since GitHub and Bitbucket don't have a way of updating one another directly. I don't know if anyone has a better idea or if we should try something else like what Shaloo suggest of just adding a link to RTD in the README pages in GenPipes. We can discuss further on Friday.

This can be achieved as follows:

  1. Incorporate Pipeline reference guide in RTD docs as .md (markdown) content instead of .rst (restructured text). Figure out a way to see if Sphinx can ingest both .rst and .md files as input. [Experiment done - possible] Step GCP Tutorial #1 Done.
  2. For remaining pipeline reference guide sections (RNA seq light, others pending) use md instead of .rst files. [RNA Seq Light - done, remaining 4 Pending]
  3. Experiment to see if .md files can be input from a different GitHub repo (GenPipes sources) directly - or at least have scripts to checkout/copy them at build time. [Done - see Makefile and confirm.py updates in #DocUpdate: Figure out a way to incorporate (updated Ref #37) README.md directly into RTD docs #38 checkins]
  4. Work with hector to see if these .md files can be reused directly in genpipes source code. [Pending]
  5. Once #DocUpdate - OpenDoor page under community needs work #4 is complete, remove the pipeline reference guide from sphinx c3g/genpipes RTD sources and ensure they are pulled at build time from genpipes sources directly. [Pending]

@rdali
Copy link
Contributor

rdali commented Nov 30, 2019

@ehenrion @pphector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants