Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default support of any error code #466

Open
Polo2 opened this issue May 25, 2023 · 1 comment
Open

Default support of any error code #466

Polo2 opened this issue May 25, 2023 · 1 comment

Comments

@Polo2
Copy link
Member

Polo2 commented May 25, 2023

Following #465,

We noticed that, if Bump.sh API returned a new HTTP error code (for example 402), currently it's necessary
to add specific code to support this 402 status error, available only with a release of the CLI.

It could be nice to add a default treatment of any HTTP error code, to make sure any error from Bump.sh API is 'understood' by CLI, and that provided error message (with JSON) is displayed.

@paulRbr
Copy link
Member

paulRbr commented May 26, 2023

That's the whole point of the 400 HTTP code and this (already handled) error treatment in the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants