Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use buf-action in CI #3071

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Use buf-action in CI #3071

merged 9 commits into from
Jun 27, 2024

Conversation

emcfarlane
Copy link
Contributor

This PR updates CI to use the new buf-action replacing buf-setup, buf-lint, buf-breaking and buf-push unifying these tasks as one. The new behaviour is as follows:

  • On pull requests: run build, lint, format and breaking change detection checks.
  • On push: build and then push the changes of the latest commit with the label of the current branch (e.g. main).
  • On delete: archive the label associated with the delete (e.g. the branch name of the PR).

Changes in behaviour:

  • Checks no longer block pushes of commits to the BSR.
  • Formatting check has been added in addition to lint and breaking.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024 •
edited
Loading

The latest Buf updates on your PR.

NameStatus
build✅ passed
lint✅ passed
format✅ passed
breaking✅ passed

@emcfarlane
Fix trigger coverage
099b926
@emcfarlane
Add on buf.lock
43337fb
@emcfarlane
Fix triggers
4c756c7 
LICENSE is covered by proto/** and README.md doesn't affect module.
bufdev
bufdev requested changes Jun 20, 2024
View reviewed changes
.github/workflows/buf-ci.yaml Outdated Show resolved Hide resolved
@nicksnyder nicksnyder mentioned this pull request Jun 26, 2024
Merged
nicksnyder added a commit to bufbuild/registry-proto that referenced this pull request Jun 26, 2024
@nicksnyder
Use the latest version of buf (#121)
57ff078 
It is more important for our repos to always track latest for dogfooding
purposes.

This is [what we are going to do in
bufbuild/buf](bufbuild/buf#3071).
@emcfarlane emcfarlane merged commit 0a636a0 into main Jun 27, 2024
11 checks passed
@emcfarlane emcfarlane deleted the ed/useBufAction branch June 27, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriable doriable doriable approved these changes

@nicksnyder nicksnyder nicksnyder approved these changes

@bufdev bufdev bufdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emcfarlane @nicksnyder @bufdev @doriable