Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --markdown formatting #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmarchini
Copy link

Markdown formatting can help users share the results on platforms like
GitHub.

Here's an example of a readme generated using eshost -t --markdown ...: https://github.com/mmarchini/proposal-error-stacks/tree/engines-comparison/testcases

Markdown formatting can help users share the results on platforms like
GitHub.

Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
@rwaldron
Copy link
Collaborator

rwaldron commented Jun 4, 2020

I prefer to not change the default reporter, but instead add a new reporter.

@mmarchini
Copy link
Author

Hi @rwaldron, thank you for the reply. I can make this change. I was mostly trying to avoid duplicated code, but that's not necessary for the new reporter. Are you ok if we have both table and cli-table as dependencies? I remember there was some limitations with cli-table to format as markdown, but I don't remember what it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants