Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process termination should also kill child processes #94

Open
gibson042 opened this issue Aug 25, 2024 · 0 comments
Open

Process termination should also kill child processes #94

gibson042 opened this issue Aug 25, 2024 · 0 comments

Comments

@gibson042
Copy link

eshost currently spawns child processes with detached: true: https://github.com/tc39/eshost/blob/3989a6bc659c1dc9e44236c10ea772a7f2d4e480/lib/ConsoleAgent.js#L100

As a result, killing an eshost process with e.g. SIGINT or SIGTERM leaves its children running. It should instead explicitly destroy() the child agents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gibson042