-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and test direct use of stdio_mgr, not as a context manager #38
Comments
I guess this is now mostly redundant due to #53 being merged? |
Yup, I think so.
Can you close it, with collaborator privileges? (I'm curious from the logistical perspective, whether the role gives you that privilege or not.)
|
I am unable to close it. |
Mmph. Limitations of collaboration on a personally-held repo, I expect. Your vision on stdio-mgr is considerably broader and more comprehensive than mine. My major desire is for it to keep serving my use-cases, which are a ~tiny subset of what you're looking for out of it. I do feel like I'm adding value by doing code review, but having me with sole control over the merge permissions &c. is seeming progressively less sensible. I'm open to changing the ownership/management structure of the project, to make it easier/faster for you to get it to where you want it to be. I'm not sure what the best change would be -- seems like creating an organization is the typical first step? |
It seems I am not a collaborator any more either, as the ability to label & assign has also disappeared. It isnt that limiting anyway; not worth creating an organisaton for. I'm not a fan of merging my own PRs anyway, and I tend to work more in other peoples personal repos than my own. It is immensely valuable to be working with you on this. Rarely is there someone else interested in providing detailed code review of this type of thing. And you've obviously thought about many of these features before, so you are not coming in cold. I'm just throwing in a few more, and some implementations which will hopefully get the project to a stage that it can get adoption / critical mass. |
Hm, odd. I will note, the last I looked, it still showed your 'collaborator' invite as pending. I'll resend. As long as the workflow is satisfactory on your end, I'm content to keep things as they are. I just don't want the limitations on how rapidly I'm able to respond/act, due to this being a side project, to lead to frustration on your end. |
Ah, accepted now. |
jayvdb:
If someone really wants to use it this way, they probably know enough about context managers and Python objects that they don't need
stdio_mgr
converted into a class (cf. #10). But, if using the machinery this way enables significant/valuable new/different/unexpected usage ofstdio_mgr
generally, then it's probably worth at least documenting & testing it, even if it doesn't warrant going all the way to #10.The text was updated successfully, but these errors were encountered: