Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator for tagger #180

Open
awest25 opened this issue Aug 20, 2024 · 1 comment
Open

Add validator for tagger #180

awest25 opened this issue Aug 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request hard medium

Comments

@awest25
Copy link
Collaborator

awest25 commented Aug 20, 2024

Work with @cj and @pavan to create a validator that highlights errors as you tag.

This will be a function that's called in the tagging page every time a row is added (saved). It will take as input the table data, active row, as well as the match metadata. It will return an array of taggingError objects.

Each taggingError object will have:

  • Description: to assist the tagger in correcting the error
  • An array of cells to highlight as an array of (row,column). (If either is null, highlight the whole column)
  • An enum called severity (with maybe 3 levels). If it's severe, the form can't be submitted until it's corrected.
@awest25 awest25 added the enhancement New feature or request label Aug 20, 2024
@awest25 awest25 self-assigned this Aug 20, 2024
@awest25
Copy link
Collaborator Author

awest25 commented Aug 27, 2024

TODO:

  • Deteting points is broken
  • Highlight whole row very lightly red when there's an error anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hard medium
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants