Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternate tagger #179

Open
awest25 opened this issue Aug 20, 2024 · 2 comments
Open

Add alternate tagger #179

awest25 opened this issue Aug 20, 2024 · 2 comments
Assignees
Labels

Comments

@awest25
Copy link
Collaborator

awest25 commented Aug 20, 2024

Overview

CJ, Pavan are developing a new set of buttons similar to those in taggerButtonData. This could be for doubles, etc.

Add a field to the upload match button that allows the person to choose what tagger to use for the match being uploaded.

Development

Ideally, the tagger button data would be stored in firebase and queried dynamically but I haven't thought of a practical way to do this. If you can't think of one either it's okay to hardcode the options into the upload form as well as hardcoding multiple versions of the tagger. Off the top of my head, create an object that maps strings to tagging panels {'doubles': doublesTaggingButtons} for example, and then query the keys of this when making the object.

Don't just pile more button data pages into services. Maybe make a separate directory for taggers or put them all in an array in the taggerButtonData file (the former makes more sense to me). Make this expandable, so that we can easily add a new tagger in the future (by adding an entry to the object as well as exporing a new tagger for example).

@awest25 awest25 assigned kesdlvi and krish1925 and unassigned kesdlvi Aug 28, 2024
@jerryshi042003
Copy link
Collaborator

A good first start to this is creating "Simple Tagger"

So instead of every shot's info, this is bare minimum to still be useful and have some summary stats. The metrics needed to be recorded are

Time Start, Time End of each point
First Serve Result (Ace, In, Out)
If First Serve Out: Second Serve Result (Ace, In, Out)
Who hit last shot:
What happened last shot: Winner, Forced Error, Unforced Error --> Determines who won the point

@Fredenck
Copy link
Collaborator

on hold (maybe 1 week): wanted metrics are being decided as board is talking to players

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants