-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timingSafeEqual #156
Open
calvinmetcalf
wants to merge
6
commits into
master
Choose a base branch
from
constant-time
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add timingSafeEqual #156
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ff65870
add timingSafeEqual
calvinmetcalf 9767b7b
use buffer shims
calvinmetcalf d1088bf
remove broken iphone
calvinmetcalf bc593db
switch to safe-buffer
calvinmetcalf 4aff6af
now rebased right
calvinmetcalf 9dd6c36
add tests for errors
calvinmetcalf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
var test = require('tape') | ||
var timingSafeEqual = require('timing-safe-equal/browser') | ||
var Buffer = require('safe-buffer').Buffer | ||
test('timingSafeEqual', function (t) { | ||
t.plan(5) | ||
t.strictEqual( | ||
timingSafeEqual(Buffer.from('foo'), Buffer.from('foo')), | ||
true, | ||
'should consider equal strings to be equal' | ||
) | ||
|
||
t.strictEqual( | ||
timingSafeEqual(Buffer.from('foo'), Buffer.from('bar')), | ||
false, | ||
'should consider unequal strings to be unequal' | ||
) | ||
|
||
t.throws(function () { | ||
timingSafeEqual(Buffer.from([1, 2, 3]), Buffer.from([1, 2])) | ||
}, 'should throw when given buffers with different lengths') | ||
|
||
t.throws(function () { | ||
timingSafeEqual('not a buffer', Buffer.from([1, 2])) | ||
}, 'should throw if the first argument is not a buffer') | ||
|
||
t.throws(function () { | ||
timingSafeEqual(Buffer.from([1, 2]), 'not a buffer') | ||
}, 'should throw if the second argument is not a buffer') | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are only doing
You should check what exception is throwing.