-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alternative currencies were previously supported... weren't they? #3
Comments
Nicehash does not have a BTC-CAD exchange rate in the list of rates from the API route I am using. I don't know if it was there previously, but currently it is not. Without a direct exchange rate, I'm not sure how best to convert BTC to CAD. |
Understood. Thanks anyway. |
Hmm... They do have a usd to cad. Would it be possible as an extra step to do the conversion from BTC to usd to cad? |
Converting BTC -> USD -> CAD would be possible and makes sense to me. I'd imagine there will be a trivial amount lost during the conversion but should be sufficient for now |
Does NiceHash display funds in CAD on the website? |
I also using IDR and it's supported by nicehash web/program, when i tried to use IDR i think it give me back BTC |
Nicehash also supports GBP, I'd love to be able to see that in the Home Assistant integration |
I submitted pull request #24 that does exactly this. |
I had the configuration working fine, upgraded to latest and now I can't view my sensors in CAD currency. This suggests to me that the only thing preventing alternative currencies is a check in the python of this plugin? Can you add support for additional currencies?
https://github.com/brianberg/ha-nicehash/blob/master/custom_components/nicehash/sensor.py#L124
Am I crazy to think it worked before? I checked the history on the code and didn't see any recent changes to it...
Version of the custom_component
72543f6
Configuration
Describe the bug
Should be able to support any currency that nicehash also supports.
Debug log
The text was updated successfully, but these errors were encountered: