Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve classify_format (with a parser?) #6

Open
brendanlong opened this issue Feb 28, 2018 · 1 comment
Open

Improve classify_format (with a parser?) #6

brendanlong opened this issue Feb 28, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@brendanlong
Copy link
Owner

classify_format uses a crazy regex and several String.contains checks. We should replace it with a Menhir parser, which would be substantially faster and probably more readable.

Note: I don't know how much the performance of this function actually matters right now, but this is an improvement I'd like to do because it's both faster and cleaner.

@brendanlong brendanlong added the enhancement New feature or request label Feb 28, 2018
@brendanlong
Copy link
Owner Author

Menhir is also just an example. Some other parser format might be reasonable too (Angstrom? something custom?). The main thing is that I want the code to be relatively straightforward (preferably functional), and preferably not have to make several passes of each string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant