You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
classify_format uses a crazy regex and several String.contains checks. We should replace it with a Menhir parser, which would be substantially faster and probably more readable.
Note: I don't know how much the performance of this function actually matters right now, but this is an improvement I'd like to do because it's both faster and cleaner.
The text was updated successfully, but these errors were encountered:
Menhir is also just an example. Some other parser format might be reasonable too (Angstrom? something custom?). The main thing is that I want the code to be relatively straightforward (preferably functional), and preferably not have to make several passes of each string.
classify_format
uses a crazy regex and severalString.contains
checks. We should replace it with a Menhir parser, which would be substantially faster and probably more readable.Note: I don't know how much the performance of this function actually matters right now, but this is an improvement I'd like to do because it's both faster and cleaner.
The text was updated successfully, but these errors were encountered: