Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test trusted setup file #6

Open
brech1 opened this issue Sep 30, 2024 · 8 comments
Open

Remove test trusted setup file #6

brech1 opened this issue Sep 30, 2024 · 8 comments

Comments

@brech1
Copy link
Owner

brech1 commented Sep 30, 2024

Description

The tests for the setup submodule rely on a sample trusted setup file from:

It should be removed and replaced with byte strings for the specific sections.

@mahmudsudo
Copy link

Can I take on this ?

@brech1
Copy link
Owner Author

brech1 commented Oct 21, 2024

Yeah! Go for it

@mahmudsudo
Copy link

what example should the ptah file data be replaced with ?

@brech1
Copy link
Owner Author

brech1 commented Oct 22, 2024

So ideally we shouldn't have a test file, we could just test with the plain array of bytes extracted from the file.

A good thing is that all the data we need to test is from the start to the file to the end of the second section, we don't need to test all the sections, just until the G2 powers.

@mahmudsudo
Copy link

how do you suggest extracting the data from the ptah file ?

@brech1
Copy link
Owner Author

brech1 commented Oct 22, 2024

I would just print the sections on screen and copy them in the code hex encoded in separate [u8]

@mahmudsudo
Copy link

should i push the refactor i have made ?

@brech1
Copy link
Owner Author

brech1 commented Oct 23, 2024

You can open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants