Q2d_sequence divide by zero in Image Simulation tutorial

[ammichalko]

Running prysm 0.21.1 (pip install) in python 3.12.7

In the Image Simulation tutorial, I am getting the following warnings after "basis = list(polynomials.Q2d_sequence(nms, r_aber, t))":

RuntimeWarning: divide by zero encountered in scalar divide
Q0 = 1 / (2 * f0)
RuntimeWarning: divide by zero encountered in scalar divide
return G_q2d(n, m) / f_q2d(n, m)
RuntimeWarning: invalid value encountered in sqrt
return np.sqrt(F_q2d(n, m) - g_q2d(n-1, m) ** 2)

[brandondube]

Thanks for the report -- this one is a latent bug caused by a change to a scipy function's handling of negative numbers, which breaks Q-coma. If you substitute the Q2D sequence for Zernikes or any other basis, it will work fine

Aside, the last release was about 2 years ago 😅 there are lots of good changes on the main git branch, which are (partially) summarized on the unfinished release notes - https://github.com/brandondube/prysm/blob/master/docs/source/releases/v0.22.rst

A not-yet-in-release notes change is the renaming of all of the polynomials.xxx_sequence functions to polynomials.xxx_seq so the naming is more consistent with _seq and _der and _der_seq for polynomials themselves as well as their derivatives