Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct name of test statistics #52

Open
manuelarnold opened this issue Aug 10, 2022 · 1 comment
Open

Correct name of test statistics #52

manuelarnold opened this issue Aug 10, 2022 · 1 comment

Comments

@manuelarnold
Copy link
Contributor

With the introduction of score-based tests, more split criteria are used in semtree than the likelihood ratio test statistic. Currently, all test statistics are incorrectly labeled as LR in outputs and plots.
I suggest the following changes:
We split tree$result$LL.max into tree$result$test.type (character value; e.g., LR or maxLM and so on) and tree$result$test.value (numeric value). I could then display the information stored in tree$result$test.type in the plot function.
Could we change that by copying and pasting, or will we break something?

@brandmaier
Copy link
Owner

Yes, very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants