Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic line colouring & steps #85

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

garydevenay
Copy link

When using a transit polyline, I added a prop to allow the line to be split and automatically coloured by the transit line type provided by Google.

I also added the journey steps to the onReady return object to facilitate the breakdown of a journey into multiple steps over many transit types.

…rt type and colour accordingly. Added the individual direction steps to the return type in order to break down the journey in to multiple steps.
@bramus
Copy link
Owner

bramus commented May 21, 2019

Thanks for this PR. It's a nice addition.

A few questions though:

  • Why did you remove region and optimizeWaypoints? This is a breaking change + has nothing to do with this PR.
  • Why did you change the mode from uppercase to lowercase? The casing is handled by the component itself. It is a breaking change (as the .ts definitions are also lagging now) + has nothing to do with this PR.

Please keep the contents of your PR limited to only the changes that it says it provides.

@garydevenay
Copy link
Author

@bramus Looks like I had some rouge VSCode extension removing unused props! Resolved both issues.

@bramus
Copy link
Owner

bramus commented May 22, 2019

@garydevenay Thanks for the extra pushed commits. It still looks a bit borked though, when you check the "files changed" tab.

Please go over your changes again. Don't be afraid to squash a few commits too, to keep the history clean.

Thanks.

@hawkeng
Copy link

hawkeng commented Jul 26, 2019

Any updates on this?

@thorizer
Copy link

thorizer commented Dec 7, 2021

this is such a useful feature. any update?

@adhendo
Copy link

adhendo commented Apr 19, 2022

this is such a useful feature. any update?

bump, any updates this would be awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants