-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add name to structure tree view #60
Conversation
needs to be rebased onto #67 [Edit] done ✔️ |
bdab7ba
to
5715673
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 97.32% 97.51% +0.19%
==========================================
Files 7 7
Lines 299 322 +23
==========================================
+ Hits 291 314 +23
Misses 8 8
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the user could toggle between acronym/name, but this is much better anyway. Happy to merge.
Sorry just seen the issues tracking progress on this. |
Description
What is this PR
Why is this PR needed?
We'd like to see the names of the structures in the tree view, not just the acronyms
What does this PR do?
Alternative, simpler-to-implement solution to a toggle between structure acronyms and names: acronyms are always shown, and names can be shown/hidden with a checkbox.
For the more difficult implementation
setData
(but make sure the user can't edit)or
the
complex-structure-tree-view
branch.References
Closes #47
How has this PR been tested?
Tests for the new checkbox functionality have been added.
Is this a breaking change?
Nope.
Does this PR require an update to the documentation?
Nope
Checklist: