Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing EFI disk's parameters should not recreate the whole VM #1515

Open
mater-345 opened this issue Sep 5, 2024 · 2 comments
Open

Changing EFI disk's parameters should not recreate the whole VM #1515

mater-345 opened this issue Sep 5, 2024 · 2 comments
Labels
✨ enhancement New feature or request

Comments

@mater-345
Copy link

Hi guys,

Changing any parameter on EFI disks currently recreating the whole VM.

For example:

+ efi_disk { # forces replacement
          + datastore_id      = "ceph-ha"
          + file_format       = "raw" # forces replacement
          + pre_enrolled_keys = false # forces replacement
          + type              = "4m" # forces replacement
        }

Tested on:

terraform {
  required_providers {
    proxmox = {
      source  = "bpg/proxmox"
      version = "0.63.0"
    }
  }

Changing anything - which can be changed - on the EFI disk should just recreate the disk, and not the entire VM.

Is there a reason for recreating the whole VM?

As far as I understand the topic, removing and adding an already created EFI disk, shouldn't brick the VM, only the boot options and some BIOS settings can be lost. I tried to test this by hand from the Proxmox GUI - removing and adding new EFI disk, and my Windows VM hasn't got any problem with boot.

Thanks in advance!

@mater-345 mater-345 added the ✨ enhancement New feature or request label Sep 5, 2024
@miberecz
Copy link

miberecz commented Sep 6, 2024

I have encountered the same issue lately. Glad that I already find it reported.

@Mrton0121
Copy link
Contributor

I also happen to have this issue! Looking forward for a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants