Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Parentless GTSFM Products in Process Graph #545

Open
kfu02 opened this issue Aug 17, 2022 · 0 comments
Open

Resolve Parentless GTSFM Products in Process Graph #545

kfu02 opened this issue Aug 17, 2022 · 0 comments

Comments

@kfu02
Copy link
Collaborator

kfu02 commented Aug 17, 2022

The process graph introduced in #540 exposes some places where our code does not align with a pure bipartite graph model, where processes produce and consume whole products, without modification. For instance, the two-view correspondences are triangulated in a class method before the BundleAdjustment Process takes over, which we had to hack around in the graph with a "Triangulated Points" Product with no source.

Screen Shot 2022-08-17 at 11 05 47 AM

Another issue arises in the Image Retriever/Loader system, where Retriever takes Loader as an argument and then simply calls Loader over a directory. This makes Loader both a Process and a input "Product" of Retriever. We can accept this as a weird quirk or potentially merge Retriever and Loader into one Process.

These should be resolved by changing the underlying code to conform to the process/product model, then fixing the UiMetadata objects in the right classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant